Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features and bug fixes #15

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Features and bug fixes #15

merged 10 commits into from
Sep 19, 2023

Conversation

P2P-Nathan
Copy link
Collaborator

Addressed #14 #12 and #9

@P2P-Nathan P2P-Nathan linked an issue Sep 16, 2023 that may be closed by this pull request
Add service.name label to all metrics #12
Closed
@github-actions
Copy link

github-actions bot commented Sep 16, 2023 •
edited
Loading

Test Results

1 files  ±0  2 suites  ±0   14s ⏱️ ±0s
4 tests ±0  4 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1999785. ± Comparison against base commit fa08c37.

♻️ This comment has been updated with latest results.

This was linked to issues Sep 16, 2023
SLO Tags can be added twice resulting in invalid data #9
Closed
Replace caller label with caller.function and caller.module #14
Closed
@P2P-Nathan P2P-Nathan self-assigned this Sep 16, 2023
@hatchan
Copy link

hatchan commented Sep 19, 2023

Thanks 🥳

@P2P-Nathan P2P-Nathan merged commit e9a6d2e into main Sep 19, 2023
2 checks passed
@P2P-Nathan P2P-Nathan deleted the p2p-nathan/july-bugs-and-features branch September 19, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatchan hatchan hatchan approved these changes

Assignees

@P2P-Nathan P2P-Nathan

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@P2P-Nathan @hatchan